fix(clerk-js): Trim emails, usernames and identifiers#2881
Conversation
🦋 Changeset detectedLatest commit: 1ddb455 The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
@desiprisg please add a description and a changeset as this does change the behavior of the components |
desiprisg
force-pushed
the
george/sdk-1417-white-space-around-email-in-signin-results-in-error-no-trim
branch
from
2045d60 to
34bce6e
Compare
|
!preview |
|
Hey @desiprisg, your preview is available.
|
| options: [], | ||
| defaultChecked: false, | ||
| }; | ||
| const transformer: NonNullable<typeof options.transformer> = options.transformer ? options.transformer : v => v; |
There was a problem hiding this comment.
🙃
| const transformer: NonNullable<typeof options.transformer> = options.transformer ? options.transformer : v => v; | |
| const transformer: NonNullable<typeof options.transformer> = options.transformer ?? v => v; |
| let value = rest.value; | ||
| let typeProps: Record<string, unknown> = { type }; | ||
| if (typeof value === 'string' && type === 'email') { | ||
| value = value.trim(); | ||
| typeProps = { pattern: '^.*@[a-zA-Z0-9\\-]+\\.[a-zA-Z0-9\\-\\.]+$' }; | ||
| } |
There was a problem hiding this comment.
❓
- Is it possible to have
type='email'but not a value that is a string ? - I'd expect with the changes made in our
useFormControlhook (below) that we wouldn't need to callvalue = value.trim();manually here. Am i missing something ?
There was a problem hiding this comment.
I just followed typescript here
There was a problem hiding this comment.
+1 on the second question. Shouldn't there be a transformer in packages/clerk-js/src/ui/components/SignUp/SignUpStart.tsx for emailAddress?
There was a problem hiding this comment.
There is a default transformer applied for type email in useFormControl
desiprisg
force-pushed
the
george/sdk-1417-white-space-around-email-in-signin-results-in-error-no-trim
branch
from
34bce6e to
1ddb455
Compare
nikosdouvlis
deleted the
george/sdk-1417-white-space-around-email-in-signin-results-in-error-no-trim
branch
5 participants
Description
Trim email addresses, usernames and the text identifier as whitespace at the start and end of the value is invalid.
To achieve the trimming for the identifier, a
transformerprop has been added touseFormControlthat can be used for other purposes as well.Checklist
npm testruns as expected.npm run buildruns as expected.Type of change